Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow testing of CLI changes from a branch #134

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Allow testing of CLI changes from a branch #134

merged 2 commits into from
Sep 11, 2023

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Aug 29, 2023 •
edited by edmorley
Loading

This PR exposes inputs on the release workflow (languages_cli_branch) that allow a branch to be passed through to the install-languages-cli action.

For automations that invoke these reusable workflows, this will allow CLI changes to be tested from a feature branch before they are merged into main.

Fixes #106
GUS-W-13955891.

@colincasey
Allow testing of CLI changes from a branch
c62da75 
This PR exposes inputs on the release workflow (`languages_cli_branch`) that allow a `branch` to be passed through to the `install-languages-cli` action.

For automations that invoke these reusable workflows, this will allow CLI changes to be tested from a feature branch before they are merged into `main`.
@colincasey colincasey added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Aug 29, 2023
@colincasey colincasey requested a review from a team as a code owner August 29, 2023 19:00
@colincasey colincasey self-assigned this Aug 29, 2023
edmorley
edmorley approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

.github/workflows/_buildpacks-prepare-release.yml Show resolved Hide resolved
.github/actions/install-languages-cli/action.yml Show resolved Hide resolved
@edmorley
Copy link
Member

@colincasey Don't forget to merge this :-)

@colincasey
Copy link
Contributor Author

colincasey commented Sep 11, 2023 •
edited
Loading

haven't forgotten @edmorley. just wanted to verify this works as expected after merging and didn't have the time last week to do so 😄

@colincasey colincasey merged commit f27dde0 into main Sep 11, 2023
@colincasey colincasey deleted the allow_cli_branch_testing branch September 11, 2023 13:48
colincasey added a commit that referenced this pull request Sep 11, 2023
@colincasey
Test branch to verify #134
34567ed
colincasey added a commit that referenced this pull request Sep 11, 2023
@colincasey
Merge branch 'main' into keep_libcnb_tools_in_sync
fa4cc79 
* main:
  Allow testing of CLI changes from a branch (#134)
  Fix bot commit signing (#133)
  Group minor/patch version Rust Dependabot updates into one PR (#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees

@colincasey colincasey

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make branch changes testable in development mode
2 participants
@colincasey @edmorley